Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placement: supports survival preferences (#40613) (#44701) #45271

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jul 10, 2023

What problem does this PR solve?

Issue Number: close #38605
pick: #40613
Problem Summary:

Is your feature request related to a problem? Please describe:
users hoped that the scale of high availability is controllable, not for the entire database. they want to distribute data across regions with specified tables. Such as:

image

Describe the feature you'd like:

Supports SQL Placement Policy Like :

ALTER PLACEMENT POLICY myplacementpolicy FOLLOWERS=5 SURVIVAL_PREFERENCES=["region", "zone", "host"]; 

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Documentation

  • Affects user behaviors
  • Contains syntax changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

placement: supports survival preferences

@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 10, 2023
@nolouch nolouch requested review from glorv and rleungx July 10, 2023 09:33
@nolouch
Copy link
Member Author

nolouch commented Jul 10, 2023

ptal @glorv @rleungx , it relative tikv/pd#6637

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 10, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glorv, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 10, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 10, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-10 09:45:02.663480368 +0000 UTC m=+325194.433819066: ☑️ agreed by glorv.
  • 2023-07-10 09:52:02.596487396 +0000 UTC m=+325614.366826109: ☑️ agreed by rleungx.

@nolouch
Copy link
Member Author

nolouch commented Jul 10, 2023

/build

1 similar comment
@nolouch
Copy link
Member Author

nolouch commented Jul 10, 2023

/build

@nolouch
Copy link
Member Author

nolouch commented Jul 10, 2023

/retest-required

@ti-chi-bot ti-chi-bot bot merged commit 7952556 into pingcap:release-6.5 Jul 10, 2023
@nolouch nolouch deleted the pick-localtion_labels branch July 11, 2023 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants